Skip to content

test: retire four raised hook timeouts by importing at module scope - #3021

Merged
os-zhuang merged 1 commit into
mainfrom
fix/flaky-lazy-import-hooks-p0p1
Jul 30, 2026
Merged

test: retire four raised hook timeouts by importing at module scope#3021
os-zhuang merged 1 commit into
mainfrom
fix/flaky-lazy-import-hooks-p0p1

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

Follow-up to #3010 (the fix) and #3015 (the §9 rule). Sweeping for the same anti-pattern — beforeAll(async () => { await import(…) }), which bills a cold module transform to hookTimeout — turned up 36 more test files, every single one already carrying a raised timeout, on an escalating ladder:

Raised to Files
15s 1
30s 33
60s 2

That ladder is the finding. Nobody raised a timeout once and moved on — the budgets went 15s → 30s → 60s, which is what "raising the timeout" looks like when it isn't actually fixing anything. One of the 30s files even leaves the escalation as advice: // Increase timeout to 30 seconds for heavy renderer imports.

This PR takes the four highest-risk ones. Each drops its raised timeout rather than raising it again — the import phase is subject to no test or hook timeout.

The four

  • plugin-markdown/src/index.test.ts (was 15s) — the twin of the file fixed in test: fix five load-sensitive flaky tests by moving module loads out of timed windows #3010: same shape, same budget, and the same comment verbatim (// Increase timeout to 15 seconds for async import). plugin-kanban proved that budget insufficient by blowing it at 15021ms, and this file's timed portion was already 5.83s of the same 15s. A live flake, not a theoretical one.
  • plugin-charts/src/index.test.ts (was 60s) — recharts-backed graph.
  • plugin-editor/src/index.test.ts (was 30s) — Monaco.
  • apps/console/src/__tests__/public-contract.test.ts (was 60s) — also folds the let contract + hook assignment into a module-scope const, now that the two side-effect imports are evaluated before the module body.

On the console file

This was the delicate one and worth being explicit about. Its assertions pin the eager/lazy registration split (#2953), so the real question was whether moving the imports changes what is loaded when. It does not:

  • static imports are evaluated in order, before the module body, so getPublicConfigs() at module scope sees exactly the registrations the hook used to produce;
  • the same two modules are loaded, so no extra plugin chunk resolves;
  • the shared setup still runs before this module is imported at all.

Its order-sensitive test — "reaches the lazily-registered blocks before their chunks load" — passes unchanged.

Results

Timed portion of each file, isolated:

File before after
plugin-markdown 5.83s 2ms
plugin-charts 2.22s 2ms
plugin-editor 1.78s 4ms
public-contract 345ms 3ms

Full suite is 100% green: 731 files passed / 1 skipped, 8521 tests passed / 24 skipped, zero failures. The unit project alone is 297/297 files and 4084/4084 tests — which also confirms no cross-file interference from the new module-scope registrations, despite that project running isolate: false.

Lint 0 errors (only pre-existing no-explicit-any warnings in untouched test bodies); type-check 38/38 successful. Test-only change, so no changeset.

One note for anyone baselining locally

The ~19 failures this repo can show on a long-lived worktree are a stale install, not a regression: node_modules/@objectstack/spec was 14.6.0 against ^17.0.0-rc.0 declared in package.json. pnpm install --prefer-offline (9s) clears every one of them — which is why the run above is all-green where earlier local runs in this worktree showed 19 failures. Already documented in AGENTS.md §9; flagging it here because it is the single easiest way to misread this suite.

Remaining

The 33-file packages/components cluster (all the same await import('../../../renderers') on 30s) is untouched here — mechanical, but a large diff that deserves its own PR. The durable fix is mechanical enforcement: the repo already has the eslint-rules/ local-plugin infrastructure, and a rule flagging await import(...) inside beforeAll/beforeEach in test files would stop this regrowing. 36 files and a 15s→30s→60s ladder are the evidence that a prose convention alone does not hold.

🤖 Generated with Claude Code

Follow-up to #3010 and the §9 rule added in #3015. A sweep for the same
anti-pattern — `beforeAll(async () => { await import(…) })`, which bills a cold
module transform to `hookTimeout` — found 36 more test files, every single one
already carrying a raised timeout, on an escalating ladder: 15s -> 30s -> 60s.
That ladder is the evidence that raising the timeout never fixed anything.

This takes the four highest-risk ones. Each drops the raised timeout instead of
raising it again; the import phase has no test or hook timeout.

- `plugin-markdown/src/index.test.ts` (was 15s) — the twin of the file fixed in
  #3010: same shape, same budget, same comment verbatim
  ("Increase timeout to 15 seconds for async import"). plugin-kanban proved that
  budget insufficient by blowing it at 15021ms, and this file's timed portion
  was already 5.83s of the same 15s. This was a live flake, not a theoretical one.
- `plugin-charts/src/index.test.ts` (was 60s) — recharts-backed graph.
- `plugin-editor/src/index.test.ts` (was 30s) — Monaco.
- `apps/console/.../public-contract.test.ts` (was 60s) — also folds the
  `let contract` + hook assignment into a module-scope `const`, now that the two
  side-effect imports are evaluated before the module body.

The console file was the delicate one: its assertions pin the eager/lazy
registration split (objectui#2953), so the concern was whether moving the
imports perturbs what is loaded when. It does not — static imports are evaluated
in order before the module body, and the shared setup still runs before this
module is imported at all. Its order-sensitive "reaches the lazily-registered
blocks before their chunks load" test passes unchanged.

Timed portion of each file, isolated (before -> after):
  plugin-markdown   5.83s  -> 2ms
  plugin-charts     2.22s  -> 2ms
  plugin-editor     1.78s  -> 4ms
  public-contract   345ms  -> 3ms

Verified: full suite 100% green — 731 files passed / 1 skipped, 8521 tests
passed / 24 skipped, zero failures. The `unit` project alone is 297/297 files
and 4084/4084 tests, which also confirms no cross-file interference from the
new module-scope registrations despite that project running `isolate: false`.

Note for anyone baselining locally: the ~19 failures this repo can show on a
long-lived worktree are a STALE INSTALL (`node_modules` @objectstack/spec 14.6.0
vs ^17.0.0-rc.0 declared), not a regression. `pnpm install --prefer-offline`
clears all of them — hence the all-green run above. Already documented in §9.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@vercel

vercel Bot commented Jul 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Jul 30, 2026 10:56am

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 27.9 KB 350 KB
Entry file index-QekY3Rio.js
Status PASS

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 8.20KB 2.97KB
app-shell (runtime-config.js) 7.42KB 2.32KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 7.57KB 2.97KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 22.10KB 4.37KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.12KB 3.41KB
auth (LoginForm.js) 17.86KB 5.29KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.43KB 2.09KB
auth (SocialSignInButtons.js) 9.60KB 3.89KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 35.76KB 9.11KB
auth (createAuthenticatedFetch.js) 4.37KB 1.69KB
auth (index.js) 2.25KB 1.01KB
auth (org-roles.js) 6.72KB 2.85KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.91KB 0.87KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 457.75KB 99.96KB
core (index.js) 2.16KB 0.78KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 134.67KB 34.24KB
fields (index.js) 222.07KB 54.35KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.46KB 0.96KB
i18n (pickLocalized.js) 1.70KB 0.83KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 25.17KB 5.80KB
i18n (useSafeTranslation.js) 3.26KB 1.44KB
layout (index.js) 38.45KB 10.67KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 4.05KB 1.53KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 6.84KB 2.42KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.67KB 1.12KB
permissions (evaluator.js) 4.41KB 1.44KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.55KB 0.71KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 44.90KB 12.35KB
plugin-charts (index.js) 60.52KB 17.11KB
plugin-chatbot (index.js) 180.09KB 42.72KB
plugin-dashboard (index.js) 111.59KB 28.74KB
plugin-designer (index.js) 210.56KB 42.56KB
plugin-detail (index.js) 216.52KB 53.02KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 104.83KB 25.30KB
plugin-gantt (index.js) 162.26KB 39.53KB
plugin-grid (index.js) 180.86KB 47.45KB
plugin-kanban (index.js) 47.82KB 13.18KB
plugin-list (index.js) 102.39KB 24.18KB
plugin-map (index.js) 16.80KB 5.24KB
plugin-markdown (index.js) 13.65KB 4.67KB
plugin-report (index.js) 40.32KB 10.53KB
plugin-timeline (index.js) 25.75KB 7.32KB
plugin-tree (index.js) 8.36KB 2.81KB
plugin-view (index.js) 85.88KB 20.99KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.67KB 2.37KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 19.28KB 6.38KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 1.02KB 0.55KB
sdui-parser (codegen.js) 4.09KB 1.74KB
sdui-parser (index.js) 3.47KB 1.54KB
sdui-parser (parse.js) 10.04KB 2.82KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 4.69KB 1.48KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 0.77KB 0.41KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (index.js) 2.00KB 0.96KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.04KB 1.93KB
types (system-fields.js) 2.39KB 1.17KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 1.08KB 0.64KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang merged commit 571c438 into main Jul 30, 2026
16 checks passed
@os-zhuang
os-zhuang deleted the fix/flaky-lazy-import-hooks-p0p1 branch July 30, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant